Issue 29527662: Noissue - Open options.html directly on Firefox for Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29527662: Noissue - Open options.html directly on Firefox for Android (Closed)

Created:
Aug. 25, 2017, 11:20 a.m. by Manish Jethani

Modified:
Aug. 25, 2017, 12:18 p.m.

Reviewers:
Sebastian Noack

CC:
Wladimir Palant

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

Description

Noissue - Open options.html directly on Firefox for Android Firefox requires the url parameter passed to tabs.query to be in a specific format: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Match_patterns When this code runs on Firefox for Android, it always sets runtime.lastError to something like "'options.html' is not a valid match pattern" and the returned tabs object is always null (even if options.html is open in a tab). Since it's guaranteed to fail, and since there's no other way to query for the tab that has the options page open ("moz-extension://" is not supported), there's no point in running that code at all. Instead, we open options.html directly. This simplifies the code a bit.