Issue 5577 - allow non-numerical build-nums for gecko-webext

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 import buildtools
@@ skipping 164 matching lines @@
         }
 
 
 def runBuild(baseDir, scriptName, opts, args, type):
     kwargs = {}
     for option, value in opts:
         if option in {'-l', '--locales'} and type == 'gecko':
             kwargs['locales'] = value.split(',')
         elif option in {'-b', '--build'}:
             kwargs['buildNum'] = value
             no_gecko_build = type not in {'gecko', 'gecko-webext'}

[kzar, 2017/08/29 13:17:45]

How about this? (untested)

if not (type.startswith('gecko') or kwargs['buildNum'].isdigit()):

             if no_gecko_build and not kwargs['buildNum'].isdigit():
                 raise TypeError('Build number must be numerical')
         elif option in {'-k', '--key'}:
             kwargs['keyFile'] = value
         elif option in {'-m', '--multi-compartment'} and type == 'gecko':
             kwargs['multicompartment'] = True
         elif option in {'-r', '--release'}:
             kwargs['releaseBuild'] = True
     if len(args) > 0:
         kwargs['outFile'] = args[0]
@@ skipping 403 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)