Issue 29527695: Issue 5577 - allow non-numerical build-nums for gecko-webext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29527695: Issue 5577 - allow non-numerical build-nums for gecko-webext (Closed)

Created:
Aug. 25, 2017, 12:33 p.m. by tlucas

Modified:
Aug. 29, 2017, 1:18 p.m.

Reviewers:
Sebastian Noack, kzar

CC:
Wladimir Palant

Visibility:
Public.

Description

Issue 5577 - allow non-numerical build-nums for gecko-webext

Patch Set 2 : #

Total comments: 1

Created: Aug. 25, 2017, 1:07 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build.py	View	1	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

tlucas

Note: building edge / chrome / gecko-webext for build / devenv worked locally

Aug. 25, 2017, 12:37 p.m. (2017-08-25 12:37:15 UTC) #1

Sebastian Noack

https://codereview.adblockplus.org/29527695/diff/29527696/build.py File build.py (left): https://codereview.adblockplus.org/29527695/diff/29527696/build.py#oldcode185 build.py:185: if type not in {'gecko', 'gecko-webext'} and not kwargs['buildNum'].isdigit(): ...

Aug. 25, 2017, 12:54 p.m. (2017-08-25 12:54:17 UTC) #2

tlucas

Patch Set 2 Proper rebase https://codereview.adblockplus.org/29527695/diff/29527696/build.py File build.py (left): https://codereview.adblockplus.org/29527695/diff/29527696/build.py#oldcode185 build.py:185: if type not in ...

Aug. 25, 2017, 1:07 p.m. (2017-08-25 13:07:49 UTC) #3

kzar

https://codereview.adblockplus.org/29527695/diff/29527708/build.py File build.py (right): https://codereview.adblockplus.org/29527695/diff/29527708/build.py#newcode185 build.py:185: no_gecko_build = type not in {'gecko', 'gecko-webext'} How about ...

Aug. 29, 2017, 1:17 p.m. (2017-08-29 13:17:45 UTC) #5

kzar

Aug. 29, 2017, 1:18 p.m. (2017-08-29 13:18:17 UTC) #6

Message was sent while issue was closed.

On 2017/08/29 13:17:45, kzar wrote:
> https://codereview.adblockplus.org/29527695/diff/29527708/build.py
> File build.py (right):
> 
> https://codereview.adblockplus.org/29527695/diff/29527708/build.py#newcode185
> build.py:185: no_gecko_build = type not in {'gecko', 'gecko-webext'}
> How about this? (untested)
> 
> if not (type.startswith('gecko') or kwargs['buildNum'].isdigit()):

Oh sorry it already landed, nevermind then.

Expand All Messages | Collapse All Messages