Unified Diff: build.py
Issue 29527695:
Issue 5577 - allow non-numerical build-nums for gecko-webext (Closed)
Patch Set:
Created Aug. 25, 2017, 1:07 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: build.py |
| diff --git a/build.py b/build.py |
| index aca63d4a7c0a7f244c3ddfc116d8f823de2297b5..b3c62a6e5da7a13db5091168cd9d1e86da55d0aa 100644 |
| --- a/build.py |
| +++ b/build.py |
| @@ -182,7 +182,8 @@ def runBuild(baseDir, scriptName, opts, args, type): |
| kwargs['locales'] = value.split(',') |
| elif option in {'-b', '--build'}: |
| kwargs['buildNum'] = value |
| - if type != 'gecko' and not kwargs['buildNum'].isdigit(): |
| + no_gecko_build = type not in {'gecko', 'gecko-webext'} |
|
kzar
2017/08/29 13:17:45
How about this? (untested)
if not (type.startswit
|
| + if no_gecko_build and not kwargs['buildNum'].isdigit(): |
| raise TypeError('Build number must be numerical') |
| elif option in {'-k', '--key'}: |
| kwargs['keyFile'] = value |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
