Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 29527808: Noissue - Use meson to build the C++ code

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by hub
Modified:
2 hours, 38 minutes ago
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Use meson to build the C++ code

Patch Set 1 #

Patch Set 2 : npm test now works #

Patch Set 3 : Rebased. Now compile output to the source directory #

Total comments: 15

Patch Set 4 : Reworked. Now build source files one by one. #

Total comments: 16

Patch Set 5 : Now build objects one by one, with dependencies, and share them. #

Total comments: 13

Patch Set 6 : Last bits of feedback #

Total comments: 13

Patch Set 7 : Updated from feedback. now require meson 0.40.0, but no default C++ compiler #

Total comments: 3

Patch Set 8 : Properly build with DEBUG #

Total comments: 6

Patch Set 9 : Pin meson version. Deprecate compile #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -123 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M .hgignore View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M README.md View 1 2 3 4 5 6 7 8 1 chunk +18 lines, -4 lines 1 comment Download
M compile View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -114 lines 1 comment Download
A meson.build View 1 2 3 4 5 6 7 8 1 chunk +167 lines, -0 lines 0 comments Download
A meson_options.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26
hub
3 months, 2 weeks ago (2017-08-25 17:17:51 UTC) #1
hub
not really for a review but more for a "here is what I came up ...
3 months, 2 weeks ago (2017-08-25 17:24:29 UTC) #2
hub
I believe Eric's CMake build system it better. meson has serious limitations like the impossibility ...
2 months ago (2017-10-10 20:18:28 UTC) #3
Wladimir Palant
I actually find this approach nicer than CMake, Meson build files seem to be more ...
2 months ago (2017-10-11 10:00:53 UTC) #4
hub
With all the suggestions, this looks better. https://codereview.adblockplus.org/29527808/diff/29532724/meson.build File meson.build (right): https://codereview.adblockplus.org/29527808/diff/29532724/meson.build#newcode1 meson.build:1: project('adblockpluscore', license: ...
2 months ago (2017-10-11 18:23:17 UTC) #5
Wladimir Palant
I wonder whether creating a tiny Python wrapper around the meson command would be worth ...
2 months ago (2017-10-11 21:01:24 UTC) #6
Wladimir Palant
Alternatively, we could have a script generate a cross-compiling configuration that could then be passed ...
2 months ago (2017-10-11 21:03:46 UTC) #7
Wladimir Palant
https://codereview.adblockplus.org/29527808/diff/29573838/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29573838/README.md#newcode30 README.md:30: mkdir build This step is unnecessary, meson will create ...
2 months ago (2017-10-12 08:46:09 UTC) #8
hub
https://codereview.adblockplus.org/29527808/diff/29573838/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29573838/README.md#newcode30 README.md:30: mkdir build On 2017/10/12 08:46:09, Wladimir Palant wrote: > ...
2 months ago (2017-10-12 18:12:11 UTC) #9
hub
I am much more optimistic about using meson now - still quirky but it actually ...
2 months ago (2017-10-12 19:50:07 UTC) #10
Wladimir Palant
A few minor issues but altogether this is looking good. https://codereview.adblockplus.org/29527808/diff/29574659/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29574659/README.md#newcode33 ...
2 months ago (2017-10-13 09:45:40 UTC) #11
hub
https://codereview.adblockplus.org/29527808/diff/29574659/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29574659/README.md#newcode33 README.md:33: make a release build. On 2017/10/13 09:45:39, Wladimir Palant ...
2 months ago (2017-10-13 18:16:54 UTC) #12
Wladimir Palant
LGTM As far as I am concerned, this can land. However, I'd like to hear ...
2 months ago (2017-10-13 18:54:06 UTC) #13
sergei
On 2017/10/11 21:01:24, Wladimir Palant wrote: > I wonder whether creating a tiny Python wrapper ...
1 month, 4 weeks ago (2017-10-16 15:27:13 UTC) #14
Eric
On 2017/10/11 10:00:53, Wladimir Palant wrote: > Also, initial CMake call > requiring a special ...
1 month, 3 weeks ago (2017-10-20 15:20:04 UTC) #15
Eric
On 2017/10/13 18:54:06, Wladimir Palant wrote: > However, I'd like to hear other > people's ...
1 month, 3 weeks ago (2017-10-20 16:54:39 UTC) #16
sergei
On 2017/10/20 16:54:39, Eric wrote: > On 2017/10/13 18:54:06, Wladimir Palant wrote: > > However, ...
1 month, 3 weeks ago (2017-10-20 19:36:24 UTC) #17
Wladimir Palant
On 2017/10/20 15:20:04, Eric wrote: > This reflects a misunderstanding of how CMake operates. CMake ...
1 month, 3 weeks ago (2017-10-20 20:08:14 UTC) #18
hub
just so that we have the latest iteration here. https://codereview.adblockplus.org/29527808/diff/29575688/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29575688/README.md#newcode23 README.md:23: ...
1 month, 2 weeks ago (2017-10-26 16:15:28 UTC) #19
Wladimir Palant
https://codereview.adblockplus.org/29527808/diff/29575688/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29575688/README.md#newcode23 README.md:23: * [ninja](https://www.ninja-build.org) On 2017/10/16 15:27:12, sergei wrote: > Just ...
1 month, 2 weeks ago (2017-10-26 19:27:00 UTC) #20
hub
https://codereview.adblockplus.org/29527808/diff/29589640/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29589640/README.md#newcode34 README.md:34: old version of meson. On 2017/10/26 19:27:00, Wladimir Palant ...
1 month, 2 weeks ago (2017-10-26 19:36:04 UTC) #21
Wladimir Palant
https://codereview.adblockplus.org/29527808/diff/29589640/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29589640/README.md#newcode34 README.md:34: old version of meson. On 2017/10/26 19:36:04, hub wrote: ...
1 month, 1 week ago (2017-11-03 10:50:12 UTC) #22
sergei
According to other code-reviews some caught up meson, so, IMO it is worth landing. However, ...
1 day, 23 hours ago (2017-12-12 17:37:29 UTC) #23
hub
updated patch https://codereview.adblockplus.org/29527808/diff/29617582/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29617582/README.md#newcode22 README.md:22: * [meson 0.40.0+](https://www.mesonbuild.com) On 2017/12/12 17:37:29, sergei ...
20 hours, 43 minutes ago (2017-12-13 20:28:59 UTC) #24
Wladimir Palant
https://codereview.adblockplus.org/29527808/diff/29617582/README.md File README.md (right): https://codereview.adblockplus.org/29527808/diff/29617582/README.md#newcode22 README.md:22: * [meson 0.40.0+](https://www.mesonbuild.com) On 2017/12/12 17:37:29, sergei wrote: > ...
6 hours, 15 minutes ago (2017-12-14 10:57:02 UTC) #25
sergei
2 hours, 50 minutes ago (2017-12-14 14:22:46 UTC) #26
I think we can continue it in the issue tracker in order to not stop the
progress here. I have created one https://issues.adblockplus.org/ticket/6200.

https://codereview.adblockplus.org/29527808/diff/29617582/README.md
File README.md (right):

https://codereview.adblockplus.org/29527808/diff/29617582/README.md#newcode22
README.md:22: * [meson 0.40.0+](https://www.mesonbuild.com)
On 2017/12/14 10:57:01, Wladimir Palant wrote:
> On 2017/12/12 17:37:29, sergei wrote:
> > Can we set the version to exactly 0.43.0 because it is working on Windows?
The
> > latest one is not working right now.
> 
> Is there an issue on it already? If not, can you file one? Insisting on
outdated
> versions or even replicating them in our repository generally isn't a good
idea,
> we should rather make sure that the bugs are fixed. Normally, we can expect
new
> meson releases to be backwards compatible, a meson release breaking things for
> us is rather unlikely - not a good justification for drastic measures.

Done, https://github.com/mesonbuild/meson/issues/2784.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5