Unified Diff: ext/background.js
Issue 29527874:
Noissue - Remove check for incognito, since it is irrelevant for Edge (Closed)
Patch Set:
Created Aug. 25, 2017, 10:36 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: ext/background.js |
| =================================================================== |
| --- a/ext/background.js |
| +++ b/ext/background.js |
| @@ -742,10 +742,7 @@ |
| let optionsUrl = "options.html"; |
| let queryInfo = {url: optionsUrl}; |
| - // extension pages can't be accessed in incognito windows. In order to |
| - // correctly mimic the way in which Chrome opens extension options, |
| - // we have to focus the options page in any other window. |
| - if (win && !win.incognito) |
|
Oleksandr
2017/08/25 22:43:25
Edge actually has win.inPrivate instead of win.inc
|
| + if (win) |
| queryInfo.windowId = win.id; |
| chrome.tabs.query(queryInfo, tabs => |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
