Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29527874: Noissue - Remove check for incognito, since it is irrelevant for Edge (Closed)

Created:
Aug. 25, 2017, 10:36 p.m. by Oleksandr
Modified:
Aug. 28, 2017, 6:53 p.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Noissue - Remove check for incognito, since it is irrelevant for Edge

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M ext/background.js View 1 chunk +1 line, -4 lines 1 comment Download

Messages

Total messages: 2
Oleksandr
https://codereview.adblockplus.org/29527874/diff/29527875/ext/background.js File ext/background.js (left): https://codereview.adblockplus.org/29527874/diff/29527875/ext/background.js#oldcode748 ext/background.js:748: if (win && !win.incognito) Edge actually has win.inPrivate instead ...
Aug. 25, 2017, 10:43 p.m. (2017-08-25 22:43:25 UTC) #1
Sebastian Noack
Aug. 26, 2017, 5:51 a.m. (2017-08-26 05:51:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld