Description of issue 5584 needs to be improved before this is pushed. The purpose of ...
2 years, 3 months ago
(2017-08-28 21:23:14 UTC)
#5
Description of issue 5584 needs to be improved before this is pushed. The
purpose of dependency update issues is letting testers know what they need to
expect. As it is now, they won't know which of the issues and commits listed are
relevant and what functionality these are touching.
On 2017/08/28 21:34:57, hub wrote: > I added the "hints for testeers" section now. I've ...
2 years, 3 months ago
(2017-08-29 07:02:45 UTC)
#7
On 2017/08/28 21:34:57, hub wrote:
> I added the "hints for testeers" section now.
I've improved this section. I also improved the description of issue 5516 - this
one was missing integration notes. Clearly, updating dependency isn't sufficient
here (meaning NOT LGTM).
https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#newcode21 include.preload.js:21: let {ElemHideEmulation} = require("content_elemHideEmulation"); Mind you, this won't work ...
2 years, 3 months ago
(2017-08-29 15:13:24 UTC)
#11
https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#newcode21 include.preload.js:21: let {ElemHideEmulation} = require("content_elemHideEmulation"); On 2017/08/29 16:46:54, hub wrote: ...
2 years, 3 months ago
(2017-08-30 10:22:20 UTC)
#13
https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js
File include.preload.js (right):
https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#...
include.preload.js:21: let {ElemHideEmulation} =
require("content_elemHideEmulation");
On 2017/08/29 16:46:54, hub wrote:
> On 2017/08/29 15:13:24, Wladimir Palant wrote:
> > Mind you, this won't work any more once we switch to WebPack, it doesn't
> expose
> > the internal require() function. So this file will have to be converted to a
> > module later.
>
> I'll add a not to issue #5080 then.
Don't worry I've taken a note of it, I need to add quite a few more details like
that to the issue already.
Issue 29529646: Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a5
(Closed)
Created 2 years, 3 months ago by hub
Modified 2 years, 3 months ago
Reviewers: Sebastian Noack, Wladimir Palant, kzar
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Comments: 3