Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a5

Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a5

[Sebastian Noack, 2017-08-28 19:24:19]

Issue 5585 seems to be unrelated of this change.

[hub, 2017-08-28 20:25:11]

sorry, wrong bug number. Fixed.

[Sebastian Noack, 2017-08-28 21:13:09]

LGTM

[Wladimir Palant, 2017-08-28 21:23:14]

Description of issue 5584 needs to be improved before this is pushed. The
purpose of dependency update issues is letting testers know what they need to
expect. As it is now, they won't know which of the issues and commits listed are
relevant and what functionality these are touching.

[hub, 2017-08-28 21:34:57]

I added the "hints for testeers" section now.

[Wladimir Palant, 2017-08-29 07:02:45]

On 2017/08/28 21:34:57, hub wrote:
> I added the "hints for testeers" section now.

I've improved this section. I also improved the description of issue 5516 - this
one was missing integration notes. Clearly, updating dependency isn't sufficient
here (meaning NOT LGTM).

[hub, 2017-08-29 13:56:02]

This properly load the module. I triple-checked.

[Sebastian Noack, 2017-08-29 14:28:54]

LGTM

[kzar, 2017-08-29 14:38:13]

LGTM

[Wladimir Palant, 2017-08-29 15:13:24]

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#...
include.preload.js:21: let {ElemHideEmulation} =
require("content_elemHideEmulation");
Mind you, this won't work any more once we switch to WebPack, it doesn't expose
the internal require() function. So this file will have to be converted to a
module later.

[hub, 2017-08-29 16:46:54]

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#...
include.preload.js:21: let {ElemHideEmulation} =
require("content_elemHideEmulation");
On 2017/08/29 15:13:24, Wladimir Palant wrote:
> Mind you, this won't work any more once we switch to WebPack, it doesn't
expose
> the internal require() function. So this file will have to be converted to a
> module later.

I'll add a not to issue #5080 then.

[kzar, 2017-08-30 10:22:20]

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29529646/diff/29530580/include.preload.js#...
include.preload.js:21: let {ElemHideEmulation} =
require("content_elemHideEmulation");
On 2017/08/29 16:46:54, hub wrote:
> On 2017/08/29 15:13:24, Wladimir Palant wrote:
> > Mind you, this won't work any more once we switch to WebPack, it doesn't
> expose
> > the internal require() function. So this file will have to be converted to a
> > module later.
> 
> I'll add a not to issue #5080 then.

Don't worry I've taken a note of it, I need to add quite a few more details like
that to the issue already.