Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/content.js

Issue 29531596: Issue 5590 - [webextension] Custom filters in the options page aren't updated (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome
Patch Set: Created Aug. 30, 2017, 9:14 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 "use strict"; 1 "use strict";
2 2
3 // Firefox 55 erroneously sends messages from the content script to the 3 // Firefox 55 erroneously sends messages from the content script to the
4 // devtools panel: 4 // devtools panel:
5 // https://bugzilla.mozilla.org/show_bug.cgi?id=1383310 5 // https://bugzilla.mozilla.org/show_bug.cgi?id=1383310
6 // As a workaround, listen for messages only if this isn't the devtools panel. 6 // As a workaround, listen for messages only if this isn't the devtools panel.
7 if (!("devtools" in chrome)) 7 if (!chrome.devtools)
Manish Jethani 2017/08/30 10:38:44 Maybe add a comment about why chrome.devtools and
Wladimir Palant 2017/08/30 12:54:54 Done.
8 { 8 {
9 // Listen for messages from the background page. 9 // Listen for messages from the background page.
10 chrome.runtime.onMessage.addListener((message, sender, sendResponse) => 10 chrome.runtime.onMessage.addListener((message, sender, sendResponse) =>
11 { 11 {
12 return ext.onMessage._dispatch(message, {}, sendResponse).includes(true); 12 return ext.onMessage._dispatch(message, {}, sendResponse).includes(true);
13 }); 13 });
14 } 14 }
15 15
16 (function() 16 (function()
17 { 17 {
(...skipping 17 matching lines...) Expand all
35 35
36 if (!port.onDisconnect.hasListeners()) 36 if (!port.onDisconnect.hasListeners())
37 { 37 {
38 port.disconnect(); 38 port.disconnect();
39 port = null; 39 port = null;
40 } 40 }
41 } 41 }
42 } 42 }
43 }; 43 };
44 }()); 44 }());
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld