Issue 29531596: Issue 5590 - [webextension] Custom filters in the options page aren't updated

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29531596: Issue 5590 - [webextension] Custom filters in the options page aren't updated (Closed)

Created:
Aug. 30, 2017, 9:14 a.m. by Wladimir Palant

Modified:
Aug. 30, 2017, 1:24 p.m.

Reviewers:
Manish Jethani

CC:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome

Visibility:
Public.

Description

Turns out, chrome.devtools is defined for all extension pages in Firefox, yet its value is undefined. It seems that Firefox is using lazy evaluation when determining whether this API should be exposed to the page.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improved comment #

Created: Aug. 30, 2017, 12:54 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ext/content.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Manish Jethani

https://codereview.adblockplus.org/29531596/diff/29531597/ext/content.js File ext/content.js (right): https://codereview.adblockplus.org/29531596/diff/29531597/ext/content.js#newcode7 ext/content.js:7: if (!chrome.devtools) Maybe add a comment about why chrome.devtools ...

Aug. 30, 2017, 10:38 a.m. (2017-08-30 10:38:44 UTC) #2

Wladimir Palant

Aug. 30, 2017, 12:54 p.m. (2017-08-30 12:54:55 UTC) #3

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages