Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/content.js

Issue 29531596: Issue 5590 - [webextension] Custom filters in the options page aren't updated (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome
Patch Set: Improved comment Created Aug. 30, 2017, 12:54 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/content.js
===================================================================
--- a/ext/content.js
+++ b/ext/content.js
@@ -1,15 +1,17 @@
"use strict";
// Firefox 55 erroneously sends messages from the content script to the
// devtools panel:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1383310
// As a workaround, listen for messages only if this isn't the devtools panel.
-if (!("devtools" in chrome))
+// Note that Firefox processes API access lazily, so chrome.devtools will always
+// exist but will have undefined as its value on other pages.
+if (!chrome.devtools)
{
// Listen for messages from the background page.
chrome.runtime.onMessage.addListener((message, sender, sendResponse) =>
{
return ext.onMessage._dispatch(message, {}, sendResponse).includes(true);
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld