Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29531680: Issue 5560 - Specify the JSDoc dependency explicitly (Closed)

Created:
Aug. 30, 2017, 3:24 p.m. by kzar
Modified:
Aug. 31, 2017, 12:35 p.m.
Visibility:
Public.

Description

Issue 5560 - Specify the JSDoc dependency explicitly

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed nit #

Total comments: 2

Patch Set 3 : Readdressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -5 lines) Patch
M build.py View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
A package.json View 1 chunk +11 lines, -0 lines 0 comments Download
A package-lock.json View 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 12
kzar
Patch Set 1
Aug. 30, 2017, 3:26 p.m. (2017-08-30 15:26:00 UTC) #1
tlucas
Hey Dave! Looks pretty good, just one tiny nit from my side ;) Best, Tristan ...
Aug. 30, 2017, 5:33 p.m. (2017-08-30 17:33:21 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json File package-lock.json (right): https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json#newcode1 package-lock.json:1: { I wonder whether we should add package-lock.json to ...
Aug. 30, 2017, 6:36 p.m. (2017-08-30 18:36:24 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json File package-lock.json (right): https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json#newcode1 package-lock.json:1: { On 2017/08/30 18:36:24, Sebastian Noack wrote: > While ...
Aug. 30, 2017, 6:50 p.m. (2017-08-30 18:50:01 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json File package-lock.json (right): https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json#newcode1 package-lock.json:1: { On 2017/08/30 18:50:01, Wladimir Palant wrote: > On ...
Aug. 30, 2017, 7:02 p.m. (2017-08-30 19:02:33 UTC) #5
tlucas
https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json File package-lock.json (right): https://codereview.adblockplus.org/29531680/diff/29531681/package-lock.json#newcode1 package-lock.json:1: { On 2017/08/30 19:02:33, Sebastian Noack wrote: > On ...
Aug. 30, 2017, 8:49 p.m. (2017-08-30 20:49:47 UTC) #6
Wladimir Palant
On 2017/08/30 19:02:33, Sebastian Noack wrote: > I wouldn't mind pinning the version of JSDoc ...
Aug. 31, 2017, 10:27 a.m. (2017-08-31 10:27:34 UTC) #7
kzar
Patch Set 2 : Addressed nit https://codereview.adblockplus.org/29531680/diff/29531681/build.py File build.py (right): https://codereview.adblockplus.org/29531680/diff/29531681/build.py#newcode522 build.py:522: command.description = 'Generate ...
Aug. 31, 2017, 10:54 a.m. (2017-08-31 10:54:35 UTC) #8
Wladimir Palant
LGTM
Aug. 31, 2017, 11:54 a.m. (2017-08-31 11:54:33 UTC) #9
tlucas
Hey dave, almost perfect - please see below. Cheers! https://codereview.adblockplus.org/29531680/diff/29532591/build.py File build.py (right): https://codereview.adblockplus.org/29531680/diff/29532591/build.py#newcode523 build.py:523: ...
Aug. 31, 2017, 12:20 p.m. (2017-08-31 12:20:58 UTC) #10
kzar
Patch Set 3 : Readdressed nit https://codereview.adblockplus.org/29531680/diff/29532591/build.py File build.py (right): https://codereview.adblockplus.org/29531680/diff/29532591/build.py#newcode523 build.py:523: 'the specified directory.' ...
Aug. 31, 2017, 12:24 p.m. (2017-08-31 12:24:55 UTC) #11
tlucas
Aug. 31, 2017, 12:31 p.m. (2017-08-31 12:31:30 UTC) #12
LGTM

Powered by Google App Engine
This is Rietveld