Noissue - Fixed: Button in filter list selection dialog is squashed

This change fixes a regression that was introduced in https://codereview.adblockplus.org/29488575/#ps29529630.

[saroyanm, 2017-09-14 13:32:54]

Sorry that it took so long,

I couldn't find any issues LGTM

[saroyanm, 2017-09-14 13:34:57]

On 2017/09/14 13:32:54, saroyanm wrote:
> Sorry that it took so long,
> 
> I couldn't find any issues LGTM

NO LGTM: Please wait a minute I commented this on wrong issue, will check this
in a minute.

[saroyanm, 2017-09-14 13:45:40]

NOT LGTM yet: I can see that button is still being squashed on my screen.

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
File skin/mobile-options.css (right):

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
skin/mobile-options.css:371: flex-shrink: 0;
The button still is being squashed with this property, maybe you can padding for
that ? Or fixed height ?

[saroyanm, 2017-09-14 13:49:13]

Sorry Thomas I mixed some stuff apparently with this review..
LGTM completely.

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
File skin/mobile-options.css (right):

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
skin/mobile-options.css:371: flex-shrink: 0;
On 2017/09/14 13:45:40, saroyanm wrote:
> The button still is being squashed with this property, maybe you can padding
for
> that ? Or fixed height ?

Sorry, this was a cache error :/ Looks fine.

[saroyanm, 2017-09-14 13:57:53]

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
File skin/mobile-options.css (right):

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
skin/mobile-options.css:371: flex-shrink: 0;
Deatil: But using Padding instead of Height might be still valid question,
considering the translations being long
something along the lines:

flex-shrink: 0;
height: auto;
padding: 10px 20px;

[Thomas Greiner, 2017-09-15 13:00:03]

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
File skin/mobile-options.css (right):

https://codereview.adblockplus.org/29531693/diff/29531694/skin/mobile-options...
skin/mobile-options.css:371: flex-shrink: 0;
On 2017/09/14 13:57:53, saroyanm wrote:
> Deatil: But using Padding instead of Height might be still valid question,
> considering the translations being long
> something along the lines:
> 
> flex-shrink: 0;
> height: auto;
> padding: 10px 20px;

You're right regarding longer texts.

Done. I made some different changes though to ensure that the button height will
never be lower than the one of the list items it refers to.

[saroyanm, 2017-09-15 15:14:01]

LGTM