Issue 5603 - Support references in parameters of exported functions

compiled/storage/FilterStorage.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 20 matching lines @@
 
 Subscription* FilterStorage::SubscriptionAt(FilterStorage::Subscriptions::size_type index) const
 {
   if (index >= mSubscriptions.size())
     return nullptr;
 
   SubscriptionPtr result(mSubscriptions[index]);
   return result.release();
 }
 
-int FilterStorage::IndexOfSubscription(const Subscription* subscription) const
+int FilterStorage::IndexOfSubscription(const Subscription& subscription) const
 {
   for (Subscriptions::size_type i = 0; i < mSubscriptions.size(); i++)
-    if (mSubscriptions[i] == subscription)
+    if (mSubscriptions[i] == &subscription)
       return i;
   return -1;
 }
 
-Subscription* FilterStorage::GetSubscriptionForFilter(const Filter* filter) const
+Subscription* FilterStorage::GetSubscriptionForFilter(const Filter& filter) const
 {
   SubscriptionPtr fallback;
 
   for (Subscriptions::size_type i = 0; i < mSubscriptions.size(); i++)
   {
     SubscriptionPtr subscription(mSubscriptions[i]);
     UserDefinedSubscription* userDefinedSubscription =
         subscription->As<UserDefinedSubscription>();
     if (userDefinedSubscription && !userDefinedSubscription->GetDisabled() &&
         userDefinedSubscription->IsDefaultFor(filter))
     {
       SubscriptionPtr result(subscription);
       return result.release();
     }
     else if (!fallback && userDefinedSubscription &&
              userDefinedSubscription->IsGeneric())
     {
       fallback = subscription;
     }
   }
 
   return fallback.release();
 }
 
-bool FilterStorage::AddSubscription(Subscription* subscription)
+bool FilterStorage::AddSubscription(Subscription& subscription)
 {
-  assert(subscription, u"Attempt to add a null subscription"_str);
-
-  if (!subscription || subscription->GetListed())
+  if (subscription.GetListed())
     return false;
 
-  mSubscriptions.emplace_back(subscription);
-  subscription->SetListed(true);
+  mSubscriptions.emplace_back(&subscription);
+  subscription.SetListed(true);
 
   FilterNotifier::SubscriptionChange(
     FilterNotifier::Topic::SUBSCRIPTION_ADDED,
     subscription
   );
   return true;
 }
 
-bool FilterStorage::RemoveSubscription(Subscription* subscription)
+bool FilterStorage::RemoveSubscription(Subscription& subscription)
 {
-  assert(subscription, u"Attempt to remove a null subscription"_str);
-
-  if (!subscription || !subscription->GetListed())
+  if (!subscription.GetListed())
     return false;
 
   for (auto it = mSubscriptions.begin(); it != mSubscriptions.end(); ++it)
   {
-    if (*it == subscription)
+    if (*it == &subscription)
     {
       mSubscriptions.erase(it);
       break;
     }
   }
-  subscription->SetListed(false);
+  subscription.SetListed(false);
 
   FilterNotifier::SubscriptionChange(
     FilterNotifier::Topic::SUBSCRIPTION_REMOVED,
     subscription
   );
   return true;
 }
 
-bool FilterStorage::MoveSubscription(Subscription* subscription,
+bool FilterStorage::MoveSubscription(Subscription& subscription,
                                      const Subscription* insertBefore)
 {
-  assert(subscription, u"Attempt to move a null subscription"_str);
-
   int oldPos = IndexOfSubscription(subscription);
+  assert(oldPos >= 0, u"Attempt to move a subscription that is not in the list"_str);
   if (oldPos == -1)
-  {
-    assert(subscription, u"Attempt to move a subscription that is not in the list"_str);
     return false;
-  }
 
   int newPos = -1;
   if (insertBefore)
-    newPos = IndexOfSubscription(insertBefore);
+    newPos = IndexOfSubscription(*insertBefore);
   if (newPos == -1)
     newPos = mSubscriptions.size();
 
   if (newPos > oldPos)
     newPos--;
 
   if (newPos == oldPos)
     return false;
 
   mSubscriptions.erase(mSubscriptions.begin() + oldPos);
-  mSubscriptions.emplace(mSubscriptions.begin() + newPos, subscription);
+  mSubscriptions.emplace(mSubscriptions.begin() + newPos, &subscription);
 
   FilterNotifier::SubscriptionChange(
     FilterNotifier::Topic::SUBSCRIPTION_MOVED,
     subscription
   );
   return true;
 }