Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29532626: Issue 5603 - Support references in parameters of exported functions (Closed)

Created:
Aug. 31, 2017, 12:36 p.m. by Wladimir Palant
Modified:
Aug. 31, 2017, 1:31 p.m.
Reviewers:
sergei, hub
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5603 - Support references in parameters of exported functions

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M compiled/FilterNotifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/bindings/generator.h View 2 chunks +5 lines, -1 line 0 comments Download
M compiled/bindings/generator.cpp View 4 chunks +5 lines, -0 lines 2 comments Download
M compiled/filter/ActiveFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M compiled/library.h View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/storage/FilterStorage.h View 1 chunk +5 lines, -5 lines 0 comments Download
M compiled/storage/FilterStorage.cpp View 2 chunks +15 lines, -23 lines 0 comments Download
M compiled/subscription/Subscription.h View 2 chunks +2 lines, -2 lines 0 comments Download
M compiled/subscription/Subscription.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.h View 1 chunk +3 lines, -3 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.cpp View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Aug. 31, 2017, 12:36 p.m. (2017-08-31 12:36:13 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29532626/diff/29532627/compiled/bindings/generator.cpp File compiled/bindings/generator.cpp (right): https://codereview.adblockplus.org/29532626/diff/29532627/compiled/bindings/generator.cpp#newcode300 compiled/bindings/generator.cpp:300: params.push_back(argName + "._pointer"); This is an implicit null check, ...
Aug. 31, 2017, 12:37 p.m. (2017-08-31 12:37:39 UTC) #2
sergei
Aug. 31, 2017, 12:59 p.m. (2017-08-31 12:59:20 UTC) #3
https://codereview.adblockplus.org/29532626/diff/29532627/compiled/bindings/g...
File compiled/bindings/generator.cpp (right):

https://codereview.adblockplus.org/29532626/diff/29532627/compiled/bindings/g...
compiled/bindings/generator.cpp:300: params.push_back(argName + "._pointer");
On 2017/08/31 12:37:39, Wladimir Palant wrote:
> This is an implicit null check, should be good enough IMHO.

LGTM, though not tested.

Powered by Google App Engine
This is Rietveld