Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/subscription/Subscription.h

Issue 29532626: Issue 5603 - Support references in parameters of exported functions (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Created Aug. 31, 2017, 12:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/subscription/Subscription.h
===================================================================
--- a/compiled/subscription/Subscription.h
+++ b/compiled/subscription/Subscription.h
@@ -38,17 +38,17 @@
void BINDINGS_EXPORTED setter(param_type value)\
{\
if (name != value)\
{\
name = value;\
if (FilterNotifier::Topic::topic != FilterNotifier::Topic::NONE)\
{\
FilterNotifier::SubscriptionChange(FilterNotifier::Topic::topic,\
- this);\
+ *this);\
}\
}\
}
#define SUBSCRIPTION_PROPERTY(type, name, topic, getter, setter) \
static_assert(std::is_arithmetic<type>::value, "SUBSCRIPTION_PROPERTY macro can only be used with arithmetic types");\
SUBSCRIPTION_PROPERTY_INTERNAL(type, type, name, topic, getter, setter)
@@ -88,17 +88,17 @@ public:
SUBSCRIPTION_PROPERTY(bool, mListed, NONE, GetListed, SetListed);
Filters::size_type BINDINGS_EXPORTED GetFilterCount() const
{
return mFilters.size();
}
Filter* BINDINGS_EXPORTED FilterAt(Filters::size_type index);
- int BINDINGS_EXPORTED IndexOfFilter(Filter* filter);
+ int BINDINGS_EXPORTED IndexOfFilter(const Filter& filter);
OwnedString BINDINGS_EXPORTED Serialize() const;
OwnedString BINDINGS_EXPORTED SerializeFilters() const;
static Subscription* BINDINGS_EXPORTED FromID(const String& id);
template<typename T>
T* As();
};

Powered by Google App Engine
This is Rietveld