Issue 29533564: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Issue 29533564: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed)

Created:
Sept. 1, 2017, 9:38 a.m. by sergei

Modified:
Sept. 7, 2017, 11:34 a.m.

Reviewers:
anton, diegocarloslima, jens

CC:
René Jeschke, Felix Dahlke

Base URL:
github.com:abby-sergz/libadblockplus-android.git

Visibility:
Public.

Description

Remove DefaultFileSystem setter which actually sets a base path for the file system. COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Total comments: 2

Created: Sept. 1, 2017, 9:38 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -41 lines)			Patch
M	libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	libadblockplus-android/jni/JniJsEngine.cpp	View	5 chunks	+9 lines, -20 lines	0 comments	Download
M	libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java	View	4 chunks	+7 lines, -13 lines	2 comments	Download
M	libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

anton

https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java (right): https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java#newcode38 libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:38: public JsEngine(final AppInfo appInfo, final WebRequest webRequest, final String ...

Sept. 1, 2017, 9:49 a.m. (2017-09-01 09:49:50 UTC) #2

sergei

Sept. 1, 2017, 9:58 a.m. (2017-09-01 09:58:34 UTC) #3

anton

On 2017/09/01 09:58:34, sergei wrote: > https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java > File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java > (right): > > https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java#newcode38 ...

Sept. 1, 2017, 10:03 a.m. (2017-09-01 10:03:58 UTC) #4

jens

Sept. 6, 2017, 11:41 a.m. (2017-09-06 11:41:41 UTC) #5

On 2017/09/01 09:58:34, sergei wrote:
>
https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-andr...
> File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
> (right):
> 
>
https://codereview.adblockplus.org/29533564/diff/29533565/libadblockplus-andr...
> libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:38:
> public JsEngine(final AppInfo appInfo, final WebRequest webRequest, final
String
> basePath)
> On 2017/09/01 09:49:50, anton wrote:
> > Since ctor becase too heavy i'd prefer to leave just 2 ctors - with appinfo
> only
> > and with all the arguments.
> > There can be lots of combinations of ctors with missing arguments so there
is
> no
> > point in having this particular ctor.
> 
> Done in https://codereview.adblockplus.org/29533581/

LGTM

Expand All Messages | Collapse All Messages