Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29533572: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed)

Created:
Sept. 1, 2017, 9:41 a.m. by sergei
Modified:
Sept. 8, 2017, 9:55 a.m.
Reviewers:
anton, diegocarloslima, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

Simplify IsAllowedConnectionCallback # depends on https://codereview.adblockplus.org/29533564/

Patch Set 1 #

Total comments: 3

Messages

Total messages: 6
sergei
Sept. 1, 2017, 9:42 a.m. (2017-09-01 09:42:57 UTC) #1
anton
https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java (right): https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java#newcode138 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java:138: IsAllowedConnectionCallback isAllowedConnectionCallback = new IsAllowedConnectionCallbackImpl(connectivityManager); it would be better ...
Sept. 1, 2017, 9:56 a.m. (2017-09-01 09:56:37 UTC) #2
sergei
https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java (right): https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java#newcode138 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java:138: IsAllowedConnectionCallback isAllowedConnectionCallback = new IsAllowedConnectionCallbackImpl(connectivityManager); On 2017/09/01 09:56:37, anton ...
Sept. 1, 2017, 10:04 a.m. (2017-09-01 10:04:23 UTC) #3
anton
https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java (right): https://codereview.adblockplus.org/29533572/diff/29533573/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java#newcode138 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java:138: IsAllowedConnectionCallback isAllowedConnectionCallback = new IsAllowedConnectionCallbackImpl(connectivityManager); On 2017/09/01 10:04:22, sergei ...
Sept. 1, 2017, 10:05 a.m. (2017-09-01 10:05:58 UTC) #4
anton
On 2017/09/01 09:42:57, sergei wrote: LGTM
Sept. 1, 2017, 10:18 a.m. (2017-09-01 10:18:23 UTC) #5
jens
Sept. 8, 2017, 9:06 a.m. (2017-09-08 09:06:53 UTC) #6
On 2017/09/01 09:42:57, sergei wrote:

LGTM

Powered by Google App Engine
This is Rietveld