Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29533581: Noissue - Remove JsEngine constructor for one special case (Closed)

Created:
Sept. 1, 2017, 9:56 a.m. by sergei
Modified:
Sept. 7, 2017, 11:40 a.m.
Reviewers:
anton, diegocarloslima, jens
CC:
René Jeschke, Felix Dahlke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

#depends on https://codereview.adblockplus.org/29533564/ COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5
sergei
Sept. 1, 2017, 9:58 a.m. (2017-09-01 09:58:11 UTC) #1
anton
On 2017/09/01 09:58:11, sergei wrote: LGTM
Sept. 1, 2017, 9:58 a.m. (2017-09-01 09:58:58 UTC) #2
anton
On 2017/09/01 09:58:58, anton wrote: > On 2017/09/01 09:58:11, sergei wrote: > > LGTM #depends ...
Sept. 1, 2017, 10 a.m. (2017-09-01 10:00:40 UTC) #3
jens
On 2017/09/01 09:58:11, sergei wrote: LGTM
Sept. 5, 2017, 9:38 a.m. (2017-09-05 09:38:22 UTC) #4
diegocarloslima
Sept. 6, 2017, 11:30 a.m. (2017-09-06 11:30:10 UTC) #5
On 2017/09/05 09:38:22, jens wrote:
> On 2017/09/01 09:58:11, sergei wrote:
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld