Issue 5598 - Fixed: Consider filter changes due to subscription change

mobile-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 109 matching lines @@
     ext.backgroundPage.sendMessage({type: "subscriptions.add", url, title});
   }
 
   function uninstallSubscription(url)
   {
     ext.backgroundPage.sendMessage({type: "subscriptions.remove", url});
   }
 
   /* Actions */
 
-  function setSubscription({disabled, title, url}, shouldAdd)
+  function setFilter({disabled, text}, action)
   {
+    if (!whitelistFilter || text != whitelistFilter)
+      return;
+
+    get("#enabled").checked = (action == "remove" || disabled);
+  }
+
+  function setSubscription(subscription, action)
+  {
+    let {disabled, filters, title, url} = subscription;
     if (disabled)
+    {
+      action = "remove";
+    }
+
+    // Handle custom subscription
+    if (/^~user/.test(url))
+    {
+      for (let filter of filters)
+      {
+        setFilter(filter, action);
+      }
       return;
+    }
 
     promisedAcceptableAdsUrl.then((acceptableAdsUrl) =>
     {
+      // Update Acceptable Ads
       if (url == acceptableAdsUrl)
       {
-        get(`#${idAcceptableAds}`).checked = true;
+        get(`#${idAcceptableAds}`).checked = (action != "remove");
         return;
       }
 
       let listInstalled = get("#subscriptions-installed");
       let installed = get(`[data-url="${url}"]`, listInstalled);
 
-      if (installed)
+      // Remove subscription
+      if (action == "remove")
+      {
+        if (installed)
+        {
+          installed.parentNode.removeChild(installed);
+        }
+
+        let recommended = get(`#${idRecommended} [data-url="${url}"]`);
+        if (recommended)
+        {
+          recommended.classList.remove("installed");
+        }
+      }
+      // Update subscription
+      else if (installed)
       {
         let titleElement = get("span", installed);
         titleElement.textContent = title || url;
       }
-      else if (shouldAdd)
+      // Add subscription
+      else if (action == "add")
       {
         let element = create(listInstalled, "li", null, {"data-url": url});
         create(element, "span", title || url);
         create(element, "button", null, {class: "remove"},
           () => uninstallSubscription(url)
         );
 
         let recommended = get(`#${idRecommended} [data-url="${url}"]`);
         if (recommended)
         {
           recommended.classList.add("installed");
         }
       }
     });
   }
 
-  function removeSubscription(url)
-  {
-    promisedAcceptableAdsUrl.then((acceptableAdsUrl) =>
-    {
-      if (url == acceptableAdsUrl)
-      {
-        get(`#${idAcceptableAds}`).checked = false;
-        return;
-      }
-
-      let installed = get(`#subscriptions-installed [data-url="${url}"]`);
-      if (installed)
-      {
-        installed.parentNode.removeChild(installed);
-      }
-
-      let recommended = get(`#${idRecommended} [data-url="${url}"]`);
-      if (recommended)
-      {
-        recommended.classList.remove("installed");
-      }
-    });
-  }
-
   function setDialog(id, options)
   {
     if (!id)
     {
       delete document.body.dataset.dialog;
       return;
     }
 
     let fields = getAll(`#dialog-${id} input`);
     for (let field of fields)
@@ skipping 36 matching lines @@
               setDialog(dialogSubscribe, {title, url});
             }
           );
         }
 
         for (let subscription of installed)
         {
           if (subscription.disabled)
             continue;
 
-          setSubscription(subscription, true);
+          setSubscription(subscription, "add");
         }
       })
       .catch((err) => console.error(err));
   }
 
   /* Listeners */
 
   function onChange(ev)
   {
     if (ev.target.id != idAcceptableAds)
@@ skipping 106 matching lines @@
 
             let toggle = get("#enabled");
             toggle.checked = !whitelisted;
 
             get("#enabled-container").hidden = false;
             break;
         }
         break;
       }
       case "filters.respond": {
-        let [filter] = msg.args;
-        if (!whitelistFilter || filter.text != whitelistFilter)
-          break;
-
-        get("#enabled").checked = (msg.action == "removed");
+        let action = (msg.action == "added") ? "add" : "remove";
+        setFilter(msg.args[0], action);
         break;
       }
       case "subscriptions.respond": {
         let [subscription] = msg.args;
         switch (msg.action)
         {
           case "added":
-            setSubscription(subscription, true);
-            break;
           case "disabled":
-            if (subscription.disabled)
-            {
-              removeSubscription(subscription.url);
-            }
-            else
-            {
-              setSubscription(subscription, true);
-            }
+            setSubscription(subscription, "add");
             break;
           case "removed":
-            removeSubscription(subscription.url);
+            setSubscription(subscription, "remove");
             break;
           case "title":
             // We're also receiving these messages for subscriptions that are
             // not installed so we shouldn't add those by accident
-            setSubscription(subscription, false);
+            setSubscription(subscription, "update");
             break;
         }
         break;
       }
     }
   }
   ext.onMessage.addListener(onMessage);
 
   ext.backgroundPage.sendMessage({
     type: "app.listen",
@@ skipping 22 matching lines @@
   get("#dialog-subscribe [name='title']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_title")
   );
 
   get("#dialog-subscribe [name='url']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_url")
   );
 }