Issue 29533638: Issue 5598 - Fixed: Consider filter changes due to subscription change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29533638: Issue 5598 - Fixed: Consider filter changes due to subscription change (Closed)

Created:
Sept. 1, 2017, 1:23 p.m. by Thomas Greiner

Modified:
Sept. 15, 2017, 12:31 p.m.

Reviewers:
saroyanm

Visibility:
Public.

Description

This review contains the following changes: - Merged `removeSubscription()` into `setSubscription()` to reduce existing/avoid further duplicated code - Added handling of custom subscriptions to `setSubscription()` - Introduced `setFilter()` function - Fixed: Disabling a subscription should remove subscription in list

Patch Set 1 #

Created: Sept. 1, 2017, 1:23 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -46 lines)			Patch
	M	mobile-options.js	View		5 chunks	+48 lines, -46 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saroyanm

Sept. 14, 2017, 1:33 p.m. (2017-09-14 13:33:58 UTC) #2

Sorry that it took so long,

I couldn't find any issues LGTM

Expand All Messages | Collapse All Messages