Issue 29535581: Issue 5379 - Remove top level paths from acceptableads.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29535581: Issue 5379 - Remove top level paths from acceptableads.com (Closed)

Created:
Sept. 4, 2017, 11:27 a.m. by juliandoucette

Modified:
Sept. 11, 2017, 4:10 p.m.

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/web.acceptableads.com

Visibility:
Public.

Description

Issue 5379 - Remove top level paths from acceptableads.com

Patch Set 1 #

Created: Sept. 4, 2017, 11:27 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -26 lines)			Patch
M	includes/about/acceptable-ads-are.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	includes/index/what-are-aa/distinction.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	includes/index/what-are-aa/placement.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	includes/index/what-are-aa/size.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	includes/index/who-benefits/ad-networks.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/index/who-benefits/ad-tech-suppliers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/index/who-benefits/advertisers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/index/who-benefits/publishers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/index/who-benefits/users.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/solutions/ad-networks.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/solutions/ad-tech-suppliers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/solutions/advertisers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	includes/solutions/publishers.md	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pages/solutions/ad-networks.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pages/solutions/ad-tech-suppliers.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pages/solutions/advertisers.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pages/solutions/publishers.md	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

juliandoucette

I didn't change the image paths because our test_server doesn't resolve internationalized images properly atm ...

Sept. 4, 2017, 11:36 a.m. (2017-09-04 11:36:32 UTC) #2

ire

Sept. 6, 2017, 10:06 p.m. (2017-09-06 22:06:15 UTC) #3

LGTM

On 2017/09/04 11:36:32, juliandoucette wrote:
> I didn't change the image paths because our test_server doesn't resolve
> internationalized images properly atm (they don't fall-back to English). I
think
> we can separate the page links issue from the image paths issue here.

I think we should update the ticket on Trac so this is clear

Expand All Messages | Collapse All Messages