Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29535600: Issue 5617 - Provide with async executor bound to Platform in the future (Closed)

Created:
Sept. 4, 2017, 12:03 p.m. by sergei
Modified:
Sept. 5, 2017, 5:03 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -52 lines) Patch
M include/AdblockPlus/Platform.h View 3 chunks +47 lines, -21 lines 0 comments Download
M shell/src/Main.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/Platform.cpp View 3 chunks +86 lines, -24 lines 2 comments Download
M test/DefaultFileSystem.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M test/GlobalJsObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M test/WebRequest.cpp View 2 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 2
sergei
https://codereview.adblockplus.org/29535600/diff/29535601/src/Platform.cpp File src/Platform.cpp (right): https://codereview.adblockplus.org/29535600/diff/29535601/src/Platform.cpp#newcode130 src/Platform.cpp:130: asyncExecutor.reset(); While the actual executor is not ready yet ...
Sept. 4, 2017, 12:16 p.m. (2017-09-04 12:16:28 UTC) #1
hub
Sept. 5, 2017, 3:24 p.m. (2017-09-05 15:24:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld