Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29536596: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed)

Created:
Sept. 5, 2017, 12:21 p.m. by sergei
Modified:
Sept. 8, 2017, 10:26 a.m.
Reviewers:
diegocarloslima, anton, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

Adjust JS code to work in the strict mode which is enabled by default in a newer libadblockplus. # depends on https://codereview.adblockplus.org/29533581/ COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java View 2 chunks +8 lines, -8 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
sergei
Sept. 5, 2017, 12:24 p.m. (2017-09-05 12:24:26 UTC) #1
anton
On 2017/09/05 12:24:26, sergei wrote: LGTM
Sept. 5, 2017, 12:26 p.m. (2017-09-05 12:26:36 UTC) #2
jens
Sept. 8, 2017, 10:17 a.m. (2017-09-08 10:17:02 UTC) #3
On 2017/09/05 12:24:26, sergei wrote:

LGTM

Powered by Google App Engine
This is Rietveld