Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

Issue 29536601: Noissue - update expected values in tests (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set: Created Sept. 5, 2017, 12:25 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 } 47 }
48 48
49 @Test 49 @Test
50 public void testDefaultPropertyValues() 50 public void testDefaultPropertyValues()
51 { 51 {
52 AppInfo appInfo = AppInfo 52 AppInfo appInfo = AppInfo
53 .builder() 53 .builder()
54 .build(); 54 .build();
55 55
56 JsEngine jsEngine = new JsEngine(appInfo); 56 JsEngine jsEngine = new JsEngine(appInfo);
57 assertEquals("0", jsEngine.evaluate("_appInfo.version").asString()); 57 assertEquals("1.0", jsEngine.evaluate("_appInfo.version").asString());
58 assertEquals("adblockplusandroid", jsEngine.evaluate("_appInfo.name").asStri ng()); 58 assertEquals("libadblockplus-android", jsEngine.evaluate("_appInfo.name").as String());
sergei 2017/09/05 12:27:17 One can find the default values which are used in
59 assertEquals("android", jsEngine.evaluate("_appInfo.application").asString() ); 59 assertEquals("android", jsEngine.evaluate("_appInfo.application").asString() );
60 assertEquals("0", jsEngine.evaluate("_appInfo.applicationVersion").asString( )); 60 assertEquals("0", jsEngine.evaluate("_appInfo.applicationVersion").asString( ));
61 assertEquals("en_US", jsEngine.evaluate("_appInfo.locale").asString()); 61 assertEquals("en_US", jsEngine.evaluate("_appInfo.locale").asString());
62 assertFalse(jsEngine.evaluate("_appInfo.developmentBuild").asBoolean()); 62 assertFalse(jsEngine.evaluate("_appInfo.developmentBuild").asBoolean());
63 } 63 }
64 } 64 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld