Issue 29536601: Noissue - update expected values in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29536601: Noissue - update expected values in tests (Closed)

Created:
Sept. 5, 2017, 12:25 p.m. by sergei

Modified:
Sept. 7, 2017, 11:44 a.m.

Reviewers:
anton, diegocarloslima, jens

CC:
Felix Dahlke, René Jeschke

Base URL:
github.com:abby-sergz/libadblockplus-android.git

Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29536601/ COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Total comments: 1

Created: Sept. 5, 2017, 12:25 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

sergei

https://codereview.adblockplus.org/29536601/diff/29536602/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java (right): https://codereview.adblockplus.org/29536601/diff/29536602/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java#newcode58 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java:58: assertEquals("libadblockplus-android", jsEngine.evaluate("_appInfo.name").asString()); One can find the default values which ...

Sept. 5, 2017, 12:27 p.m. (2017-09-05 12:27:17 UTC) #1

anton

On 2017/09/05 12:27:17, sergei wrote: > https://codereview.adblockplus.org/29536601/diff/29536602/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java > File > libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java > (right): > > ...

Sept. 5, 2017, 12:28 p.m. (2017-09-05 12:28:19 UTC) #2

jens

Sept. 6, 2017, 7:52 a.m. (2017-09-06 07:52:14 UTC) #3

On 2017/09/05 12:27:17, sergei wrote:
>
https://codereview.adblockplus.org/29536601/diff/29536602/libadblockplus-andr...
> File
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java
> (right):
> 
>
https://codereview.adblockplus.org/29536601/diff/29536602/libadblockplus-andr...
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java:58:
> assertEquals("libadblockplus-android",
> jsEngine.evaluate("_appInfo.name").asString());
> One can find the default values which are used in the test here
>
https://github.com/adblockplus/libadblockplus-android/blob/master/libadblockp...

LGTM

Expand All Messages | Collapse All Messages