Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/about/index.html

Issue 29536625: Issue 5103 - Added padding to 1/2 column images on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Created Sept. 5, 2017, 12:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« includes/index/style.html ('K') | « includes/index/style.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title=What are Acceptable Ads? 1 title=What are Acceptable Ads?
2 description=Acceptable Ads are nonintrusive ad formats that are accepted by ad b locking users and allow content creators to monetize their content. 2 description=Acceptable Ads are nonintrusive ad formats that are accepted by ad b locking users and allow content creators to monetize their content.
3 custom=1 3 custom=1
4 4
5 <style>
6 #aa-star
7 {
8 display: block;
9 max-width: 60%;
ire 2017/09/06 22:56:58 Why 60%? Should we use padding instead, as done on
juliandoucette 2017/09/11 16:15:59 This was opinionated. I thought 60% looked right a
ire 2017/09/12 08:14:17 I think the size of the image looks good at 60%. M
10 margin: 0em auto;
11 }
12
13 @media(max-width: 767px)
14 {
15 #aa-star
16 {
17 display: none;
ire 2017/09/06 22:56:58 Why is this image completely removed on smaller sc
juliandoucette 2017/09/11 16:15:59 This was opinionated. I thought that it didn't loo
ire 2017/09/12 08:14:17 This is also opinionated, but I think it looks goo
18 }
19 }
20 </style>
21
5 <div class="container"> 22 <div class="container">
6 <h1>{{what-are-acceptable-ads-heading[What are Acceptable Ads heading] What ar e Acceptable Ads?}}</h1> 23 <h1>{{what-are-acceptable-ads-heading[What are Acceptable Ads heading] What ar e Acceptable Ads?}}</h1>
7 <hr> 24 <hr>
8 <div class="row section"> 25 <div class="row section">
9 <div class="col-6 expand-on-tablet"> 26 <div class="col-6 expand-on-tablet">
10 <? include about/what-are-acceptable-ads ?> 27 <? include about/what-are-acceptable-ads ?>
11 </div> 28 </div>
12 </div> 29 </div>
13 </div> 30 </div>
14 31
15 <div class="bg-accent section"> 32 <div class="bg-accent section">
16 <div class="container center"> 33 <div class="container center">
17 <? include about/treating-people-with-respect ?> 34 <? include about/treating-people-with-respect ?>
18 </div> 35 </div>
19 </div> 36 </div>
20 37
21 <div class="container section"> 38 <div class="container section">
22 <h2>{{acceptable-ads-heading[Acceptable Ads... heading] Acceptable Ads...}}</h 2> 39 <h2>{{acceptable-ads-heading[Acceptable Ads... heading] Acceptable Ads...}}</h 2>
23 <div class="row"> 40 <div class="row">
24 <div class="col-6 push-6"> 41 <div class="col-6 push-6">
25 <img class="block" alt="{{acceptable-ads-image-alt(Acceptable Ads... image alt text) Acceptable Ads promotional image}}" src="/img/png/what-is-acceptablea ds.png" /> 42 <img id="aa-star" alt="{{ acceptable-ads-image-alt[image alt text] Accepta ble Ads promotional image }}" src="/img/png/what-is-acceptableads.png" />
26 </div> 43 </div>
27 <div class="col-6 pull-6"> 44 <div class="col-6 pull-6">
28 <? include about/acceptable-ads-are ?> 45 <? include about/acceptable-ads-are ?>
29 </div> 46 </div>
30 </div> 47 </div>
31 </div> 48 </div>
OLDNEW
« includes/index/style.html ('K') | « includes/index/style.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld