Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29536625: Issue 5103 - Added padding to 1/2 column images on acceptableads.com (Closed)

Created:
Sept. 5, 2017, 12:53 p.m. by juliandoucette
Modified:
Sept. 12, 2017, 1:27 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 5103 - Added padding to 1/2 column images on acceptableads.com

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -23 lines) Patch
M includes/index/style.html View 1 chunk +45 lines, -22 lines 2 comments Download
M pages/about/index.html View 2 chunks +18 lines, -1 line 6 comments Download

Messages

Total messages: 5
juliandoucette
Sept. 5, 2017, 12:53 p.m. (2017-09-05 12:53:45 UTC) #1
ire
Thanks Julian. Here are my initial comments https://codereview.adblockplus.org/29536625/diff/29536626/includes/index/style.html File includes/index/style.html (right): https://codereview.adblockplus.org/29536625/diff/29536626/includes/index/style.html#newcode3 includes/index/style.html:3: .masthead-img img ...
Sept. 6, 2017, 10:56 p.m. (2017-09-06 22:56:58 UTC) #2
juliandoucette
Thanks Ire! I may have been a little too lazy and/or opinionated about this one. ...
Sept. 11, 2017, 4:15 p.m. (2017-09-11 16:15:59 UTC) #3
ire
> Thanks Ire! > > I may have been a little too lazy and/or opinionated ...
Sept. 12, 2017, 8:14 a.m. (2017-09-12 08:14:18 UTC) #4
juliandoucette
Sept. 12, 2017, 1:27 p.m. (2017-09-12 13:27:01 UTC) #5
Ack - I'm going to see if I can come up with a more general solution for this.

Powered by Google App Engine
This is Rietveld