Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/about/index.html

Issue 29536625: Issue 5103 - Added padding to 1/2 column images on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Created Sept. 5, 2017, 12:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« includes/index/style.html ('K') | « includes/index/style.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/about/index.html
===================================================================
--- a/pages/about/index.html
+++ b/pages/about/index.html
@@ -1,12 +1,29 @@
title=What are Acceptable Ads?
description=Acceptable Ads are nonintrusive ad formats that are accepted by ad blocking users and allow content creators to monetize their content.
custom=1
+<style>
+ #aa-star
+ {
+ display: block;
+ max-width: 60%;
ire 2017/09/06 22:56:58 Why 60%? Should we use padding instead, as done on
juliandoucette 2017/09/11 16:15:59 This was opinionated. I thought 60% looked right a
ire 2017/09/12 08:14:17 I think the size of the image looks good at 60%. M
+ margin: 0em auto;
+ }
+
+ @media(max-width: 767px)
+ {
+ #aa-star
+ {
+ display: none;
ire 2017/09/06 22:56:58 Why is this image completely removed on smaller sc
juliandoucette 2017/09/11 16:15:59 This was opinionated. I thought that it didn't loo
ire 2017/09/12 08:14:17 This is also opinionated, but I think it looks goo
+ }
+ }
+</style>
+
<div class="container">
<h1>{{what-are-acceptable-ads-heading[What are Acceptable Ads heading] What are Acceptable Ads?}}</h1>
<hr>
<div class="row section">
<div class="col-6 expand-on-tablet">
<? include about/what-are-acceptable-ads ?>
</div>
</div>
@@ -17,15 +34,15 @@
<? include about/treating-people-with-respect ?>
</div>
</div>
<div class="container section">
<h2>{{acceptable-ads-heading[Acceptable Ads... heading] Acceptable Ads...}}</h2>
<div class="row">
<div class="col-6 push-6">
- <img class="block" alt="{{acceptable-ads-image-alt(Acceptable Ads... image alt text) Acceptable Ads promotional image}}" src="/img/png/what-is-acceptableads.png" />
+ <img id="aa-star" alt="{{ acceptable-ads-image-alt[image alt text] Acceptable Ads promotional image }}" src="/img/png/what-is-acceptableads.png" />
</div>
<div class="col-6 pull-6">
<? include about/acceptable-ads-are ?>
</div>
</div>
</div>
« includes/index/style.html ('K') | « includes/index/style.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld