libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java - Issue 29536629: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java

Issue 29536629: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comment Created Sept. 8, 2017, 12:20 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java

index 49e61f85029901d27841b156fa6283d28d0f6864..2741bb8e70b172460c52829e9609683b7e965a99 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java

@@ -21,7 +21,7 @@ import org.adblockplus.libadblockplus.FilterEngine;

import org.adblockplus.libadblockplus.LazyWebRequest;

import org.adblockplus.libadblockplus.WebRequest;

-public abstract class BaseFilterEngineTest extends BaseJsEngineTest

+public abstract class BaseFilterEngineTest extends BasePlatformTest

{

protected FilterEngine filterEngine;

@@ -29,7 +29,7 @@ public abstract class BaseFilterEngineTest extends BaseJsEngineTest

protected void setUp() throws Exception

{

super.setUp();

- filterEngine = new FilterEngine(jsEngine);

+ filterEngine = platform.getFilterEngine();

}

@Override

@@ -44,7 +44,6 @@ public abstract class BaseFilterEngineTest extends BaseJsEngineTest

if (filterEngine != null)

{

Thread.sleep(200); // let FS finish its operations

- filterEngine.dispose();

filterEngine = null;

}