Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java

Issue 29536629: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set: address comment Created Sept. 8, 2017, 12:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java
diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java
index 2f512c2ea5a77ddec4fac9aa8fa7d180acbad844..2516c6769f913cb515b3d3814b2be801842d3290 100644
--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java
+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java
@@ -27,7 +27,7 @@ import org.adblockplus.libadblockplus.WebRequest;
import android.content.Context;
import android.test.InstrumentationTestCase;
-public abstract class BaseJsEngineTest extends InstrumentationTestCase
+public abstract class BaseJsEngineTest extends BasePlatformTest
{
protected JsEngine jsEngine;
@@ -35,35 +35,6 @@ public abstract class BaseJsEngineTest extends InstrumentationTestCase
protected void setUp() throws Exception
{
super.setUp();
-
- jsEngine = new JsEngine(AppInfo.builder().build(), createLogSystem(), createWebRequest(),
- getContext().getFilesDir().getAbsolutePath());
- }
-
- @Override
- protected void tearDown() throws Exception
- {
- if (jsEngine != null)
- {
- jsEngine.dispose();
- jsEngine = null;
- }
- }
-
- // If the method returns null then a default implementation of the Log System
- // provided by libadblockplus is used.
- protected LogSystem createLogSystem()
- {
- return null;
- }
-
- protected WebRequest createWebRequest()
- {
- return new ThrowingWebRequest();
- }
-
- protected Context getContext()
- {
- return getInstrumentation().getTargetContext();
+ jsEngine = platform.getJsEngine();
}
}

Powered by Google App Engine
This is Rietveld