Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29536678: Noissue - fix a warning class 'IV8IsolateProvider' was previously declared as a struct [-Wmismatche… (Closed)

Created:
Sept. 5, 2017, 3:43 p.m. by hub
Modified:
Sept. 5, 2017, 9:03 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Noissue - fix a warning class 'IV8IsolateProvider' was previously declared as a struct [-Wmismatched-tags]

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Total comments: 1

Patch Set 3 : RE-rebase properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/AdblockPlus/Platform.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
hub
Sept. 5, 2017, 3:43 p.m. (2017-09-05 15:43:06 UTC) #1
hub
a warning was shown with some compiler flags.
Sept. 5, 2017, 3:44 p.m. (2017-09-05 15:44:08 UTC) #2
sergei
I think it will be easier to simply drop the second patchset. See my comment ...
Sept. 5, 2017, 5:54 p.m. (2017-09-05 17:54:51 UTC) #3
sergei
forgot to mention, don't forget review URL in the commit message.
Sept. 5, 2017, 5:55 p.m. (2017-09-05 17:55:30 UTC) #4
hub
Review URL already in commit message. Rebased properly thigs time.
Sept. 5, 2017, 6:18 p.m. (2017-09-05 18:18:58 UTC) #5
sergei
Sept. 5, 2017, 7:07 p.m. (2017-09-05 19:07:48 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld