Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/IFileSystem.h

Issue 29537555: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed)
Patch Set: Created Sept. 6, 2017, 8:11 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | include/AdblockPlus/ITimer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/IFileSystem.h
diff --git a/include/AdblockPlus/IFileSystem.h b/include/AdblockPlus/IFileSystem.h
index 463be394e4e56f09d3d9b28d72e3eda2c70608ec..619b27139b6b1b744c2aaa2b11b44453d03f90e6 100644
--- a/include/AdblockPlus/IFileSystem.h
+++ b/include/AdblockPlus/IFileSystem.h
@@ -1,6 +1,6 @@
/*
* This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
*
* Adblock Plus is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
@@ -41,8 +41,6 @@ namespace AdblockPlus
StatResult()
{
exists = false;
- isDirectory = false;
- isFile = false;
lastModified = 0;
}
@@ -52,16 +50,6 @@ namespace AdblockPlus
bool exists;
/**
- * File is a directory.
- */
- bool isDirectory;
-
- /**
- * File is a regular file.
- */
- bool isFile;
-
- /**
* POSIX time of the last modification.
*/
int64_t lastModified;
@@ -88,37 +76,37 @@ namespace AdblockPlus
/**
* Reads from a file.
- * @param path File path.
+ * @param fileName File name.
* @param callback The function called on completion with the input data.
*/
- virtual void Read(const std::string& path,
+ virtual void Read(const std::string& fileName,
const ReadCallback& callback) const = 0;
/**
* Writes to a file.
- * @param path File path.
+ * @param fileName File name.
* @param data The data to write.
* @param callback The function called on completion.
*/
- virtual void Write(const std::string& path,
+ virtual void Write(const std::string& fileName,
const IOBuffer& data,
const Callback& callback) = 0;
/**
* Moves a file (i.e.\ renames it).
- * @param fromPath Current path to the file.
- * @param toPath New path to the file.
+ * @param fromFileName Current file name.
+ * @param toFileName New file name.
* @param callback The function called on completion.
*/
- virtual void Move(const std::string& fromPath, const std::string& toPath,
+ virtual void Move(const std::string& fromFileName, const std::string& toFileName,
const Callback& callback) = 0;
/**
* Removes a file.
- * @param path File path.
+ * @param fileName File name.
* @param callback The function called on completion.
*/
- virtual void Remove(const std::string& path, const Callback& callback) = 0;
+ virtual void Remove(const std::string& fileName, const Callback& callback) = 0;
/**
* Callback type for the asynchronous Stat call.
@@ -129,24 +117,17 @@ namespace AdblockPlus
/**
* Retrieves information about a file.
- * @param path File path.
+ * @param fileName File name.
* @param callback The function called on completion.
*/
- virtual void Stat(const std::string& path,
+ virtual void Stat(const std::string& fileName,
const StatCallback& callback) const = 0;
-
- /**
- * Returns the absolute path to a file.
- * @param path File path (can be relative or absolute).
- * @return Absolute file path.
- */
- virtual std::string Resolve(const std::string& path) const = 0;
};
/**
- * Shared smart pointer to a `IFileSystem` instance.
+ * Unique smart pointer to to a `IFileSystem` instance.
*/
- typedef std::shared_ptr<IFileSystem> FileSystemPtr;
+ typedef std::unique_ptr<IFileSystem> FileSystemPtr;
}
#endif
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | include/AdblockPlus/ITimer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld