Issue 29537555: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29537555: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed)

Created:
Sept. 6, 2017, 8:11 a.m. by anton

Modified:
Sept. 8, 2017, 9:40 a.m.

Reviewers:
sergei, diegocarloslima, jens

CC:
Felix Dahlke, René Jeschke

Visibility:
Public.

Description

Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 I've built git:ae05138f20e4513a354cd7396ac6c6db0c1ecf7e (equal to hg: 566f64c8a2a8). Note i've started providing arm64 binaries

Patch Set 1 #

Created: Sept. 6, 2017, 8:11 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -408 lines)			Patch
A	android_arm64-v8a/libadblockplus.a	View	Binary file		0 comments	Download
A +	android_arm64-v8a/libv8_base.a	View	Binary file		0 comments	Download
A	android_arm64-v8a/libv8_libbase.a	View	Binary file		0 comments	Download
A	android_arm64-v8a/libv8_libplatform.a	View	Binary file		0 comments	Download
A	android_arm64-v8a/libv8_libsampler.a	View	Binary file		0 comments	Download
A	android_arm64-v8a/libv8_snapshot.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libadblockplus.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_base.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_libbase.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_libplatform.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_libsampler.a	View	Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_snapshot.a	View	Binary file		0 comments	Download
M	android_x86/libadblockplus.a	View	Binary file		0 comments	Download
M	android_x86/libv8_base.a	View	Binary file		0 comments	Download
M	android_x86/libv8_libbase.a	View	Binary file		0 comments	Download
M	android_x86/libv8_libplatform.a	View	Binary file		0 comments	Download
M	android_x86/libv8_libsampler.a	View	Binary file		0 comments	Download
M	android_x86/libv8_snapshot.a	View	Binary file		0 comments	Download
M	include/AdblockPlus.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	include/AdblockPlus/AppInfo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	include/AdblockPlus/DefaultFileSystem.h	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	include/AdblockPlus/DefaultLogSystem.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	include/AdblockPlus/DefaultWebRequest.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	include/AdblockPlus/FileSystem.h	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	include/AdblockPlus/FilterEngine.h	View	5 chunks	+7 lines, -11 lines	0 comments	Download
M	include/AdblockPlus/IFileSystem.h	View	5 chunks	+14 lines, -33 lines	0 comments	Download
M	include/AdblockPlus/ITimer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/IWebRequest.h	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	9 chunks	+32 lines, -86 lines	0 comments	Download
M	include/AdblockPlus/JsValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/LogSystem.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/AdblockPlus/Notification.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
A	include/AdblockPlus/Platform.h	View	1 chunk	+188 lines, -0 lines	0 comments	Download
M	include/AdblockPlus/ReferrerMapping.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	include/AdblockPlus/Scheduler.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
D	include/AdblockPlus/WebRequest.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

On 2017/09/06 08:15:29, anton wrote:

LGTM

Expand All Messages | Collapse All Messages