metadata.edge - Issue 29537686: Issue 5623 - Change the version format of devbuilds of ABP for Microsoft Edge

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.edge

Issue 29537686: Issue 5623 - Change the version format of devbuilds of ABP for Microsoft Edge (Closed)

Patch Set: Created Sept. 6, 2017, 6:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 version = 0.9.11.0	5 version = 0.9.11
Oleksandr 2017/09/06 18:52:10 Windows Store certification process checks the ver Windows Store certification process checks the version parameter with this regexp: ^(0\|[1-9][0-9]{0,3}\|[1-5][0-9]{4}\|6[0-4][0-9]{3}\|65[0-4][0-9]{2}\|655[0-2][0-9]\|6553[0-5])(\.(0\|[1-9][0-9]{0,3}\|[1-5][0-9]{4}\|6[0-4][0-9]{3}\|65[0-4][0-9]{2}\|655[0-2][0-9]\|6553[0-5])){0,3}$ It looks like both `0.9.11` and `0.9.11.1835` should be accepted. So this change should be enough for both development and release builds. The only way to know for sure is to try publishing it though.
6 basename = adblockplusedge	6 basename = adblockplusedge

7 app_id_release = EyeoGmbH.AdblockPlus	7 app_id_release = EyeoGmbH.AdblockPlus

8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild	8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild

9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

10 background_color = red	10 background_color = red

11 extension_id_release = 1.0	11 extension_id_release = 1.0

12 backgroundScripts = lib/localforage.min.js	12 backgroundScripts = lib/localforage.min.js

13 ext/common.js	13 ext/common.js

14 ext/background.js	14 ext/background.js

15 lib/compat.js	15 lib/compat.js

(...skipping 15 matching lines...) Expand all Loading...
31	31

32	32

33 [compat]	33 [compat]

34 edge = 40.15063.0.0	34 edge = 40.15063.0.0

35 windows = 10.0.15063.0/12.0.0.0	35 windows = 10.0.15063.0/12.0.0.0

36	36

37 [appx_assets]	37 [appx_assets]

38 logo_44.png = icons/abp-44.png	38 logo_44.png = icons/abp-44.png

39 logo_50.png = icons/abp-50.png	39 logo_50.png = icons/abp-50.png

40 logo_150.png = icons/abp-150.png	40 logo_150.png = icons/abp-150.png

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »