Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29537686: Issue 5623 - Change the version format of devbuilds of ABP for Microsoft Edge (Closed)

Created:
Sept. 6, 2017, 6:47 p.m. by Oleksandr
Modified:
Sept. 7, 2017, 1 a.m.
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 5623 - Change the version format of devbuilds of ABP for Microsoft Edge

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M metadata.edge View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
Oleksandr
https://codereview.adblockplus.org/29537686/diff/29537687/metadata.edge File metadata.edge (left): https://codereview.adblockplus.org/29537686/diff/29537687/metadata.edge#oldcode5 metadata.edge:5: version = 0.9.11.0 Windows Store certification process checks the ...
Sept. 6, 2017, 6:52 p.m. (2017-09-06 18:52:10 UTC) #1
Sebastian Noack
LGTM
Sept. 7, 2017, 12:52 a.m. (2017-09-07 00:52:54 UTC) #2
Sebastian Noack
Sept. 7, 2017, 12:55 a.m. (2017-09-07 00:55:18 UTC) #3
Please push to "master" and then rebase the "edge" bookmark. Technically, we are
in code freeze for the Chrome/Opera release, but this change doesn't have any
effects on any builds except on the build for Microsoft Edge, so this is fine.

Powered by Google App Engine
This is Rietveld