Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29539831: Issue 5648 - Include lib/popupBlocker.js on Firefox (Closed)

Created:
Sept. 8, 2017, 6:59 p.m. by Manish Jethani
Modified:
Sept. 15, 2017, 11:51 a.m.
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5648 - Include lib/popupBlocker.js on Firefox

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M lib/popupBlocker.js View 1 chunk +36 lines, -30 lines 0 comments Download
M metadata.gecko-webext View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Manish Jethani
Sept. 8, 2017, 6:59 p.m. (2017-09-08 18:59:50 UTC) #1
Sebastian Noack
Sept. 8, 2017, 8:35 p.m. (2017-09-08 20:35:28 UTC) #2
LGTM. But please don't push to "master", for now, see my comment in the other
review.

Powered by Google App Engine
This is Rietveld