Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29539835: Noissue - Check for devtools.panels API support (Closed)

Created:
Sept. 8, 2017, 7:11 p.m. by Manish Jethani
Modified:
Sept. 8, 2017, 9:33 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Check for devtools.panels API support

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move check outside handler and add comment about Firefox version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M devtools.js View 1 1 chunk +37 lines, -31 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
I discovered this while testing for another issue on Firefox 53. There's no devtools.panels, yet ...
Sept. 8, 2017, 7:17 p.m. (2017-09-08 19:17:57 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29539835/diff/29539836/devtools.js File devtools.js (right): https://codereview.adblockplus.org/29539835/diff/29539836/devtools.js#newcode29 devtools.js:29: if (enabled && "panels" in chrome.devtools) There should be ...
Sept. 8, 2017, 8:29 p.m. (2017-09-08 20:29:06 UTC) #2
Sebastian Noack
On 2017/09/08 19:17:57, Manish Jethani wrote: > Also, maybe it's time to update this check ...
Sept. 8, 2017, 8:32 p.m. (2017-09-08 20:32:17 UTC) #3
Manish Jethani
On 2017/09/08 20:32:17, Sebastian Noack wrote: > On 2017/09/08 19:17:57, Manish Jethani wrote: > > ...
Sept. 8, 2017, 9:06 p.m. (2017-09-08 21:06:03 UTC) #4
Manish Jethani
Patch Set 2: Move check outside handler and add comment about Firefox version I've added ...
Sept. 8, 2017, 9:19 p.m. (2017-09-08 21:19:54 UTC) #5
Sebastian Noack
Sept. 8, 2017, 9:29 p.m. (2017-09-08 21:29:38 UTC) #6
LGTM. Please push to the "next" bookmark.

Powered by Google App Engine
This is Rietveld