devtools.js - Issue 29539835: Noissue - Check for devtools.panels API support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: devtools.js

Issue 29539835: Noissue - Check for devtools.panels API support (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Created Sept. 8, 2017, 7:11 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: devtools.js

===================================================================

--- a/devtools.js

+++ b/devtools.js

@@ -21,17 +21,17 @@

chrome.runtime.sendMessage(

{

type: "prefs.get",

key: "show_devtools_panel"

enabled =>

{

- if (enabled)

+ if (enabled && "panels" in chrome.devtools)

Sebastian Noack 2017/09/08 20:29:06 There should be a comment mentioning to the effect

Manish Jethani 2017/09/08 21:19:54 Done.

{

chrome.devtools.panels.create(

"Adblock Plus",

"icons/detailed/abp-48.png",

"devtools-panel.html",

panel =>

{

panel.onShown.addListener(window =>

« no previous file with comments | « no previous file | no next file » | no next file with comments »