Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(551)

Issue 29542628: Issue 3994 - Do not register ABB to Androids AccountManager (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by jens
Modified:
11 months, 4 weeks ago
Reviewers:
anton, diegocarloslima
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 3994 - Do not register ABB to Androids AccountManager

Patch Set 1 : Issue 3994 - Do not register ABB to Androids AccountManager #

Total comments: 1

Patch Set 2 : Issue 3994 - Do not register ABB to Androids AccountManager #

Total comments: 1

Patch Set 3 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in View 1 2 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 7
jens
1 year ago (2017-09-12 13:33:22 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29542628/diff/29542631/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in File mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in (right): https://codereview.adblockplus.org/29542628/diff/29542631/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in#newcode2 mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in:2: <!-- Instead of commenting out, we usually remove the ...
1 year ago (2017-09-12 14:22:28 UTC) #2
jens
On 2017/09/12 14:22:28, diegocarloslima wrote: > https://codereview.adblockplus.org/29542628/diff/29542631/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in > File mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in > (right): > > https://codereview.adblockplus.org/29542628/diff/29542631/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in#newcode2 ...
1 year ago (2017-09-12 14:24:48 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29542628/diff/29542708/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in File mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in (left): https://codereview.adblockplus.org/29542628/diff/29542708/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in#oldcode12 mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in:12: Actually, It was just to remove the commented code. ...
1 year ago (2017-09-14 17:59:27 UTC) #4
jens
On 2017/09/14 17:59:27, diegocarloslima wrote: > https://codereview.adblockplus.org/29542628/diff/29542708/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in > File mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in > (left): > > https://codereview.adblockplus.org/29542628/diff/29542708/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in#oldcode12 ...
1 year ago (2017-09-15 07:27:08 UTC) #5
diegocarloslima
On 2017/09/15 07:27:08, jens wrote: > On 2017/09/14 17:59:27, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29542628/diff/29542708/mobile/android/services/manifests/FxAccountAndroidManifest_services.xml.in ...
1 year ago (2017-09-15 13:16:52 UTC) #6
anton
11 months, 4 weeks ago (2017-09-25 06:49:57 UTC) #7
On 2017/09/12 13:33:22, jens wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5