Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29542705: Noissue - rename functions checking that the String is writable (Closed)

Created:
Sept. 12, 2017, 2:27 p.m. by sergei
Modified:
Sept. 19, 2017, 10:04 a.m.
Reviewers:
hub, Wladimir Palant
Base URL:
https://github.com/adblockplus/adblockpluscore.git
Visibility:
Public.

Description

This renaming is helpful in order to avoid confusion because String_assert_readonly(bool readOnly) actually checks whether the string is not read-only. Review URL: https://codereview.adblockplus.org/29542705/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M compiled/String.h View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3
sergei
Sept. 12, 2017, 2:28 p.m. (2017-09-12 14:28:39 UTC) #1
hub
LGTM
Sept. 12, 2017, 4:53 p.m. (2017-09-12 16:53:11 UTC) #2
Wladimir Palant
Sept. 19, 2017, 8:53 a.m. (2017-09-19 08:53:43 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld