Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29542744: Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0 (Closed)

Created:
Sept. 12, 2017, 7:49 p.m. by Sebastian Noack
Modified:
Sept. 12, 2017, 10:10 p.m.
Reviewers:
tlucas
CC:
Oleksandr
Visibility:
Public.

Description

Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improved docstring for compliance with PEP-257 #

Total comments: 2

Patch Set 3 : Removed redundant whitespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M packagerEdge.py View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M tests/test_packagerEdge.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Sebastian Noack
https://codereview.adblockplus.org/29542744/diff/29542745/tests/test_packagerEdge.py File tests/test_packagerEdge.py (right): https://codereview.adblockplus.org/29542744/diff/29542745/tests/test_packagerEdge.py#newcode216 tests/test_packagerEdge.py:216: {'metadata': metadata, 'version': '1.2.3.4'}, The previous change broke this ...
Sept. 12, 2017, 7:52 p.m. (2017-09-12 19:52:33 UTC) #1
tlucas
Hey Sebastian, this looks alright - just one stylistic nit below. Best, Tristan https://codereview.adblockplus.org/29542744/diff/29542745/packagerEdge.py File ...
Sept. 12, 2017, 9:24 p.m. (2017-09-12 21:24:18 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29542744/diff/29542745/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29542744/diff/29542745/packagerEdge.py#newcode76 packagerEdge.py:76: four components with the last component being zero (e.g. ...
Sept. 12, 2017, 9:35 p.m. (2017-09-12 21:35:46 UTC) #3
tlucas
https://codereview.adblockplus.org/29542744/diff/29542810/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29542744/diff/29542810/packagerEdge.py#newcode75 packagerEdge.py:75: Flake8 fails on this line: ./packagerEdge.py:75:1: W293 blank line ...
Sept. 12, 2017, 9:38 p.m. (2017-09-12 21:38:08 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29542744/diff/29542810/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29542744/diff/29542810/packagerEdge.py#newcode75 packagerEdge.py:75: On 2017/09/12 21:38:08, tlucas wrote: > Flake8 fails on ...
Sept. 12, 2017, 9:41 p.m. (2017-09-12 21:41:18 UTC) #5
tlucas
Sept. 12, 2017, 9:42 p.m. (2017-09-12 21:42:39 UTC) #6
No problem - fwiw it's some practice for me :)

LGTM

Powered by Google App Engine
This is Rietveld