Issue 5666 - Replace 4th component of version in AppxManifest.xml with 0

packagerEdge.py

Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -70,10 +70,14 @@
     return json.loads(files[path])
 
 
-def pad_version(version):
-    """Make sure version number has 4 groups of digits."""
-    groups = (version.split('.') + ['0', '0', '0'])[:4]
-    return '.'.join(groups)
+def fix_version(version):
+    """
+    Prepares a version number for usage in AppxManifest.xml which requires
+    four components with the last component being zero (e.g. 12.34.56.0).

[tlucas, 2017/09/12 21:24:18]

You should use the imperative for docstrings, e.g. "Prepare a version number..."


In case you really need a multi-line docstring, you should also add a one-line
summary and a blank line, just before the multi-line description.

Or you could transform it into a one-liner, e.g.:
    """Prepare a version number to adhere to the required pattern x.x.x.0."""

What do you think about this?

[Sebastian Noack, 2017/09/12 21:35:45]

Done.

+    """
+    components = version.split('.')[:3]
+    components.extend(['0'] * (4 - len(components)))
+    return '.'.join(components)
 
 
 def create_appx_manifest(params, files, release_build=False):
@@ -82,7 +86,7 @@
     metadata = params['metadata']
     w = params['windows_version'] = {}
     w['min'], w['max'] = metadata.get('compat', 'windows').split('/')
-    params['version'] = pad_version(params['version'])
+    params['version'] = fix_version(params['version'])
 
     metadata_suffix = 'release' if release_build else 'devbuild'
     app_extension_id = 'extension_id_' + metadata_suffix