README.md - Issue 29544671: Issue 5509 - add ESLint config

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29544671: Issue 5509 - add ESLint config (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created Sept. 14, 2017, 12:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 libadblockplus	1 libadblockplus

2 ==============	2 ==============

3	3

4 A C++ library offering the core functionality of Adblock Plus.	4 A C++ library offering the core functionality of Adblock Plus.

5	5

6 Getting/updating the dependencies	6 Getting/updating the dependencies

7 ---------------------------------	7 ---------------------------------

8	8

9 libadblockplus has dependencies that aren't part of this repository. They are	9 libadblockplus has dependencies that aren't part of this repository. They are

10 retrieved and updated during the build process, but you can also manually update	10 retrieved and updated during the build process, but you can also manually update

(...skipping 252 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
263 ### Windows	263 ### Windows

264	264

265 set "GYP_DEFINES=libv8_include_dir=../../v8-bins/win/include libv8_lib_dir=. ./../v8-bins/win/Win32/<(CONFIGURATION_NAME) libv8_no_build=true"	265 set "GYP_DEFINES=libv8_include_dir=../../v8-bins/win/include libv8_lib_dir=. ./../v8-bins/win/Win32/<(CONFIGURATION_NAME) libv8_no_build=true"

266 createsolution.bat	266 createsolution.bat

267	267

268 ### *nix	268 ### *nix

269	269

270 [ANDROID_NDK_ROOT=....] make [android_...] LIBV8_LIB_DIR=../v8-bins/libs LIB V8_INCLUDE_DIR=../v8-bins/include	270 [ANDROID_NDK_ROOT=....] make [android_...] LIBV8_LIB_DIR=../v8-bins/libs LIB V8_INCLUDE_DIR=../v8-bins/include

271	271

272 The rest is the same.	272 The rest is the same.

	273

	274 Linting

	275 -------

	276

	277 You can lint the code using [ESLint](http://eslint.org).

	278

	279 npm run eslint

	280

	281 In order to set up ESLint and

	282 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.

	283

OLD	NEW

« no previous file with comments | « .hgignore ('k') | lib/.eslintrc.json » ('j') | no next file with comments »