Issue 29544671: Issue 5509 - add ESLint config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29544671: Issue 5509 - add ESLint config (Closed)

Created:
Sept. 14, 2017, 12:25 p.m. by sergei

Modified:
Sept. 15, 2017, 4:36 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

So far it's merely the prerequisites and the config and one has to run it manually. This step should be done first because otherwise it's difficult to guess what else changes are required.

Patch Set 1 #

Created: Sept. 14, 2017, 12:25 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -0 lines)			Patch
A	.eslintignore	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	.eslintrc.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	.hgignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	README.md	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	lib/.eslintrc.json	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	package.json	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

sergei

On 2017/09/14 17:20:34, hub wrote: > btw, do you want me to make the JS ...

Sept. 14, 2017, 6:46 p.m. (2017-09-14 18:46:25 UTC) #4

hub

Sept. 15, 2017, 1:37 p.m. (2017-09-15 13:37:17 UTC) #5

Filed https://issues.adblockplus.org/ticket/5685 to that effect.

Expand All Messages | Collapse All Messages