Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: popup.js

Issue 29544720: Noissue - Remove ext.closePopup() (Closed)
Patch Set: Created Sept. 15, 2017, 12:54 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/popup.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: popup.js
===================================================================
--- a/popup.js
+++ b/popup.js
@@ -77,7 +77,7 @@
);
document.getElementById("options").addEventListener("click", () =>
{
- ext.showOptions(ext.closePopup);
+ ext.showOptions(window.close);
}, false);
// Set up collapsing of menu items
@@ -128,7 +128,7 @@
page.sendMessage({type: "composer.content.startPickingElement"});
// Close the popup after a few seconds, so user doesn't have to
- activateClickHide.timeout = window.setTimeout(ext.closePopup, 5000);
+ activateClickHide.timeout = window.setTimeout(window.close, 5000);
}
function cancelClickHide()
« no previous file with comments | « ext/popup.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld