Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29544720: Noissue - Remove ext.closePopup() (Closed)

Created:
Sept. 15, 2017, 12:54 a.m. by Sebastian Noack
Modified:
Sept. 15, 2017, 3:11 p.m.
Reviewers:
Manish Jethani, kzar
Visibility:
Public.

Description

Noissue - Remove ext.closePopup()

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M ext/popup.js View 1 chunk +0 lines, -5 lines 0 comments Download
M popup.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
As discussed before, there is no reason to wrap window.close() in ext.closePopup(), anymore. For reference, ...
Sept. 15, 2017, 12:56 a.m. (2017-09-15 00:56:38 UTC) #1
kzar
LGTM
Sept. 15, 2017, 9:56 a.m. (2017-09-15 09:56:30 UTC) #2
Manish Jethani
Sept. 15, 2017, 10:18 a.m. (2017-09-15 10:18:01 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld