Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29545651: Issue 5696 - Rename Components to ComponentsObject (Closed)

Created:
Sept. 15, 2017, 2:09 p.m. by Manish Jethani
Modified:
Sept. 15, 2017, 8:05 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5696 - Rename Components to ComponentsObject

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M lib/compat.js View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
Sept. 15, 2017, 2:09 p.m. (2017-09-15 14:09:24 UTC) #1
Manish Jethani
Patch Set 1 This seems to be just a local variable so it can just ...
Sept. 15, 2017, 2:10 p.m. (2017-09-15 14:10:06 UTC) #2
Sebastian Noack
LGTM as a quick fix. (To be landed in "next".) But please file a follow ...
Sept. 15, 2017, 5:41 p.m. (2017-09-15 17:41:11 UTC) #3
Manish Jethani
On 2017/09/15 17:41:11, Sebastian Noack wrote: > LGTM as a quick fix. (To be landed ...
Sept. 15, 2017, 6:06 p.m. (2017-09-15 18:06:38 UTC) #4
Wladimir Palant
Sept. 15, 2017, 8:05 p.m. (2017-09-15 20:05:50 UTC) #5
Message was sent while issue was closed.
LGTM, it seems that we aren't using Components directly anywhere. We should
switch to standard APIs for Core however, so that this emulation isn't necessary
in the first place.

Powered by Google App Engine
This is Rietveld