Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29545667: Noissue - update v8 to version 5.8.283.32 (Closed)

Created:
Sept. 15, 2017, 4:39 p.m. by sergei
Modified:
Sept. 19, 2017, 1:53 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

Review: https://codereview.adblockplus.org/29545667

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M dependencies View 1 chunk +4 lines, -4 lines 5 comments Download
M v8.gypi View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
sergei
https://codereview.adblockplus.org/29545667/diff/29545668/dependencies File dependencies (right): https://codereview.adblockplus.org/29545667/diff/29545668/dependencies#newcode1 dependencies:1: _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/ Git revisions are taken from ...
Sept. 15, 2017, 4:48 p.m. (2017-09-15 16:48:19 UTC) #1
hub
Sept. 15, 2017, 6:26 p.m. (2017-09-15 18:26:06 UTC) #2
LGTM

Doesn't fix the Fedora 26 build issue though.

Powered by Google App Engine
This is Rietveld